Skip to content

Revert 258 ossec pkill fix pr 1.x #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2022
Merged

Revert 258 ossec pkill fix pr 1.x #544

merged 1 commit into from
Jan 27, 2022

Conversation

gregharvey
Copy link
Member

No description provided.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gregharvey gregharvey changed the base branch from devel to 1.x January 27, 2022 10:38
nfawbert
nfawbert approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@nfawbert nfawbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting issue;

roles/ossec/handlers/main.yml#L9
ignore-errors Use failed_when and specify error conditions instead of using ignore_errors

It's just a warning (ignore_errors) but is necessary.

@nfawbert nfawbert merged commit c0e8b06 into 1.x Jan 27, 2022
@gregharvey gregharvey deleted the revert-258-ossec_pkill_fix-PR-1.x branch January 27, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfawbert nfawbert nfawbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregharvey @nfawbert